[CIR][CUDA][HIP] Add Support for stream per thread #1997
+59
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RiverDave
requested review from
andykaylor,
bcardosolopes,
lanza and
xlauko
as code owners
RiverDave
changed the title
RiverDave
force-pushed
the
users/riverdave/cuda-per-thread-stream
branch
from
9949967 to
4069ee9
Compare
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
bcardosolopes
approved these changes
Nov 20, 2025
Member
bcardosolopes
left a comment
bcardosolopes
left a comment
There was a problem hiding this comment.
LGTM minor pending nits. (@koparasy, any feedback?)
| LangOptions::GPUDefaultStreamKind::PerThread) | ||
| llvm_unreachable("NYI"); | ||
| LangOptions::GPUDefaultStreamKind::PerThread) { | ||
| if (cgf.getLangOpts().HIP) |
Member
There was a problem hiding this comment.
Please add tests that also cover HIP!
Contributor
|
LGTM, please add the HIP test as well |
RiverDave
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests for all kernell calls are originally located at: https://github.com/llvm/clangir/blob/main/clang/test/CodeGenCUDA/kernel-call.cu we might need to re-organize all of our already existing tests for parity and correctness in the future. If anybody's interested in what stream-per-thread actually means: https://developer.nvidia.com/blog/gpu-pro-tip-cuda-7-streams-simplify-concurrency/